Don't be a "Did it work? Yay! Ship it!" coder

 •  Filed under Programmer, Programming, Software, Software Development

I'm working on a longer post on what it means to write high quality code, but until that's done, I wanted to call out what I see as the tell-tale sign of less experienced programmers. It's when you see that "Did it work? Yay! Ship it!" quality to code. Let's call the person who does this, the DIWYSI coder.

So what are the signs of the DIWYSI coder?

The most obvious sign is lint, lazy writing or code structure, and lots of notes to self that never get acted upon. I don't mean that code has to be perfectly structured. I'm really not a perfectionist. It's just that someone who is only trying to get the code working and not thinking of other programmers is going to just hack, hack, hack, and once it works, commit and move on.

This kind of code often looks like:

    const thing = function someFun(){
      If ( something)
          // How does this even work?!?!
          {
             Do_the_thing() }
    };

This is exaggerated, of course, but it's not far off some stuff I've seen.

Keep this in mind -- great code is much more than just writing something that runs correctly. "Did it work?" should be the first question you ask, not the only question. If it doesn't run, then yeah, it's not good. Anyone working as a programmer today ought to be able to write code that runs. Writing code that runs and that another programmer can pick up and understand is much better.